Skip to content

oc --config is deprecated, use --kubeconfig instead #14121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 6, 2020
Merged

oc --config is deprecated, use --kubeconfig instead #14121

openshift-merge-robot merged 1 commit into from
Dec 6, 2020

Conversation

@guillaumerose
Copy link
Contributor

@guillaumerose guillaumerose commented Dec 6, 2020 •
edited
Loading

Hopefully fix integration tests of the CVO.

I believe it started to fail after the merge of openshift/oc#660.
I guess we need to create a new master-sidecar file for 4.7.

@guillaumerose guillaumerose changed the title oc —-config is deprecated, use —-kubeconfig instead oc --config is deprecated, use --kubeconfig instead Dec 6, 2020
@guillaumerose guillaumerose mentioned this pull request Dec 6, 2020
Merged
@guillaumerose
Copy link
Contributor Author

guillaumerose commented Dec 6, 2020

ping @sdodson

@sdodson
Copy link
Member

sdodson commented Dec 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2020
@bparees
Copy link
Contributor

bparees commented Dec 6, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, guillaumerose, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit 420cbe0 into openshift:master Dec 6, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 6, 2020

@guillaumerose: Updated the following 5 configmaps:

  • prow-job-master-sidecar-4.6 configmap in namespace ci at cluster vsphere using the following files:
    • key master-sidecar-4.6.yaml using file ci-operator/templates/master-sidecar-4.6.yaml
  • prow-job-master-sidecar-4.6 configmap in namespace ci at cluster api.ci using the following files:
    • key master-sidecar-4.6.yaml using file ci-operator/templates/master-sidecar-4.6.yaml
  • prow-job-master-sidecar-4.6 configmap in namespace ci at cluster app.ci using the following files:
    • key master-sidecar-4.6.yaml using file ci-operator/templates/master-sidecar-4.6.yaml
  • prow-job-master-sidecar-4.6 configmap in namespace ci at cluster build01 using the following files:
    • key master-sidecar-4.6.yaml using file ci-operator/templates/master-sidecar-4.6.yaml
  • prow-job-master-sidecar-4.6 configmap in namespace ci at cluster build02 using the following files:
    • key master-sidecar-4.6.yaml using file ci-operator/templates/master-sidecar-4.6.yaml
Details

In response to this:

Hopefully fix integration tests of the CVO.

I believe it started to fail after the merge of openshift/oc#660.
I guess we need to create a new master-sidecar file for 4.7.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

Assignees

@sdodson sdodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guillaumerose @sdodson @bparees @openshift-ci-robot @openshift-merge-robot